Re: [PATCH] xfs/348: don't run a fuzzer in the auto group

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Wed, Feb 22, 2017 at 11:53:33PM -0800, Darrick J. Wong wrote:
> xfs/348 can cause the kernel to crash by blowing the i_rwsem assert in
> xfs_destroy_inode on the corrupted inode.  Since this is a fuzzer test
> anyway (it calls xfs_db to break the scratch fs), move it to the fuzzers
> group.

I agreed fuzzers group should be added, but I'm not sure about removing
auto group. I think this is a good & targeted regression test that
excrises the code path that patch "xfs: sanity check directory inode
di_size" fixed.

And further more, IMO shared/005,7 and xfs/133,4 belong to auto (and
quick) group too, they're all targeted regression test cases.

If you're worried about crashing kernel by running these tests in auto
group, perhaps we can consider adding them to dangerous group, then run
check with "./check -g auto -x dangerous". But these bugs are all fixed,
the tests shouldn't bring any trouble if running on newer kernels :)

Thanks,
Eryu
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux