On Wed, Feb 22, 2017 at 11:30:13AM -0800, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@xxxxxxxxxx>
>
> Commit ebbfbefce909 ("test-appliance: add support for xfstests to use
> EXT_MKFS_OPTIONS") changed the test appliances to set both MKFS_OPTIONS
> and EXT_MKFS_OPTIONS when starting 'check'. However, MKFS_OPTIONS was
> not exported into the environment, so it was not actually being
> recognized. Fix this by exporting it.
>
Oops. Nice catch!
BTW, I am very much thinking about sending in a patch upstream so that
xfstests recognizes EXT_MKFS_OPTIONS. The problem is once we do this
it will break people's config file or other systems that wrap xfstests
if they are just using the bare MKFS_OPTIONS. I'm making
kvm-xfstests/gce-xfstests be able to be agile with respect to this
proposed change, by setting both, but this could potentially break
other people.
There's a larger issue here, which is that xfstests as a whole is very
inconsistent, on a file system by file system basis, about whether or
not <FSTYPE>_MKFS_OPTIONS and <FSTYPE>_MOUNT_OPTIONS are used or not.
It might be nice to fix the larger problem, but for now I'm more
focused on making ext4 consistent with most (but not all) of the other
file systems supported by xfstests.
- Ted
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
