On Mon, Feb 20, 2017 at 01:02:59PM +0800, Xiao Yang wrote:
> 1) If the kernel bug has been fixed, stat command fails to get i_size
> and reports "Structure needs cleaning". So we use debugfs -R "stat"
> instead of stat command to make sure debugfs sets negative i_size.
> These cases have been broken by commit 0e13e40b247a1 ("shared/005,7:
> make sure debugfs sets negative i_size").
>
> 2) shared/007 passes unexpectedly on RHEL6.8GA and RHEL6.9Beta
> because of invalid argument. When debugfs fails to set i_size
> to -512, dd with direct flag fails and reports "invalid argument".
> So we can add strict check.
But you've already added the check for i_size and _notrun if debugfs
failed to set i_size to -512, there's no chance for dd to hit EINVAL.
And I think any error dd is hitting is acceptable, as long as test runs
(which means i_size was set to -1/-512 successfully). So I don't think
we need the check on dd's output. Did I miss anything?
Thanks,
Eryu
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
