On Sat, Feb 04, 2017 at 12:15:26PM +0800, Eryu Guan wrote: > > +# get standard environment, filters and checks > > +. ./common/rc > > +. ./common/filter > > +. common/reflink > > For consistency, ". ./common/reflink" looks better. Sure, this was fat fingered anyway :) > > + > > +# real QA test starts here > > +_supported_fs generic > > +_supported_os Linux > > + > > +_require_test > > +_require_test_reflink > > +_require_cp_reflink > > This seems not necessary, cp is not used and xfs_io reflink command is > checked in _require_test_reflink. Yeah - the first version used cp, but I changed it later so this an be safely dropped. > Otherwise looks good to me. I can fix them at commit time. Please do, thanks a lot! -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
