Re: [PATCH v2 1/2] xfs: test per-inode DAX flag by IO

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Thu, Jan 19, 2017 at 01:49:25PM -0700, Ross Zwisler wrote:
> On Thu, Jan 19, 2017 at 06:13:57PM +0800, Xiong Zhou wrote:
...snip..
> > +	ret = munmap(map, len);
> > +	if (ret < 0)
> > +		err_exit("munmap", len, argv[4]);
> 
> Small nit: you munmap() to clean up the mmap(), but you don't close fd or fd2.

Thanks Ross and Eryu reviewing!

I'll send v3 of this patch shortly.

--
Xiong
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux