Re: [PATCH v3] xfstests-bld: correct file permissions on test appliance files

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Wed, Dec 28, 2016 at 03:08:20PM -0600, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@xxxxxxxxxx>
> 
> The xfstests-bld repository may have been cloned with a umask that
> masked out the group and/or the other bits.  When using --update-files
> in this situation or when creating a GCE image, the VM ended up in a
> state where non-root users were unable to execute anything, which made
> all tests using the fsgqa user get skipped.  Fix this by copying the r
> and x user bits to the group and other bits when creating files.tar.gz.
> Also set the owner and group to root while we're at it.
> 
> Note that git doesn't actually store file owners, groups, or any mode
> bits other than "is the file executable"?  So this patch really just
> enforces a consistent, sane default for this "unstored" metadata.
> 
> Signed-off-by: Eric Biggers <ebiggers@xxxxxxxxxx>

As it turns out, update_xfstests() in kvm-xfstests/test-appliance/gen-image also
needs to be updated.  (I'm not sure why it wasn't a problem for me before.)  So
I'll send yet another version of this patch.

Eric
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux