On Thu, Dec 22, 2016 at 11:55:51AM -0500, Theodore Ts'o wrote: > On Wed, Dec 21, 2016 at 10:06:27AM -0800, Eric Biggers wrote: > > From: Eric Biggers <ebiggers@xxxxxxxxxx> > > > > The xfstests-bld repository may have been cloned with a umask that > > masked out the other bits. When using --update-files in this situation > > or when creating a GCE image, the VM ended up in a state where non-root > > users were unable to execute anything, which made all tests using the > > fsgqa user get skipped. Fix this by copying the r and x group bits to > > the other bits when creating files.tar.gz. Also set the owner and group > > to root while we're at it. > > Wouldn't it be better to use "--mode=go+u-w"? This will solve the > problem for those people who use a umask of 077. > > - Ted Yes, you're correct. I was thinking that the user and group permissions could be different on the files, but actually git can only store mode 755 or 644, so we might as well use go+u-w. I'll send a revised patch. Eric -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
