On Tue, Dec 20, 2016 at 10:55:34AM -0700, Ross Zwisler wrote:
> On Tue, Dec 06, 2016 at 09:04:01PM -0700, Ross Zwisler wrote:
> > This patch addresses the following build warnings:
> >
> > fsx.c: In function 'do_punch_hole':
> > fsx.c:940:3: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
> > if (!quiet && testcalls > simulatedopcount)
> > ^~
> > fsx.c:942:4: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'
> > log4(OP_PUNCH_HOLE, offset, length, FL_SKIPPED);
> > ^~~~
> > fsx.c:947:3: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
> > if (!quiet && testcalls > simulatedopcount)
> > ^~
> > fsx.c:949:4: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'
> > log4(OP_PUNCH_HOLE, offset, length, FL_SKIPPED);
> > ^~~~
> > fsx.c: In function 'do_zero_range':
> > fsx.c:995:3: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
> > if (!quiet && testcalls > simulatedopcount)
> > ^~
> > fsx.c:997:4: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'
> > log4(OP_ZERO_RANGE, offset, length, FL_SKIPPED |
> > ^~~~
> > [CC] growfiles
> > growfiles.c: In function 'notify_others':
> > growfiles.c:1458:6: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
> > if ( Forker_pids[ind] != Pid )
> > ^~
> > growfiles.c:1462:10: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'
> > kill(Forker_pids[ind], SIGUSR2);
> > ^~~~
> >
> > The warnings in fsx.c were just spacing issues of the form:
> >
> > if (length == 0) {
> > if (!quiet && testcalls > simulatedopcount)
> > prt("skipping zero length punch hole\n");
> > log4(OP_PUNCH_HOLE, offset, length, FL_SKIPPED);
> > return;
> > }
> >
> > Where the log4() call just needs to be unindented. log4() calls elsewhere
> > in that same file are not protected with any sort of 'quiet' check, and
> > commonly follow prt() calls which are. See doread(), domapread(), etc.
> >
> > The warning from growfiles.c was actually a bug. notify_others() is
> > looping through the Forker_pids[] array and sending SIGUSR2 to all other
> > processes. However, with the current logic it only *logs* the kill for
> > other processes, and kills all other processes plus the Forker_pids[] entry
> > that matches 'Pid'.
> >
> > Signed-off-by: Ross Zwisler <ross.zwisler@xxxxxxxxxxxxxxx>
> > Cc: Dave Chinner <david@xxxxxxxxxxxxx>
> > Cc: Lukas Czerner <lczerner@xxxxxxxxxx>
> > Cc: Allison Henderson <achender@xxxxxxxxxxxx>
> > Cc: Christoph Hellwig <hch@xxxxxx>
> > Cc: Nathan Scott <nathans@xxxxxxx>
>
> Ping on this patch.
Sorry, it was already applied. My apologies for the noise.
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
