On Tue, Dec 13, 2016 at 02:12:55PM +0800, Eryu Guan wrote: > On Mon, Dec 05, 2016 at 11:21:03AM -0800, Eric Biggers wrote: > > This is the third version of the patch series to add some xfstests for > > filesystem-level encryption. The new tests are designed to run on any > > filesystem that implements the "fscrypt" API, currently ext4 and f2fs. > > (fscrypt support for ubifs is also under development, but it looks like > > xfstests doesn't have ubifs support yet.) > > > > The new tests are designed to complement, not replace, doing a full > > xfstests run with encryption enabled, which for ext4 can currently be > > done by using the test_dummy_encryption mount option. > > These tests look good to me now overall, from fstests perspective of > view. I tested them with 4.9 kernel with ext4 encryption enabled, latest > e2fsprogs and latest xfsprogs plus the set|get_policy patch. All tests > passed on ext4. Comments go to individual patch. > > But I'm not so familiar with this new encryption API, it would be good > to have some reviews on the tests from other fscrypt developers too. > Hi Eryu, thanks for the review. I'm planning to send a v4 of the patchset to address your comments. I've let people with more involvement in filesystem encryption know that this needs to be reviewed. (And some are Cc'ed here; Ted and Jaegeuk are the official fscrypto maintainers.) Thanks, Eric -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
