On Fri, Dec 02, 2016 at 11:35:04AM +0800, Eryu Guan wrote: ... > > > + if [ $ok -eq 0 ]; then > > > + echo "*** mount output ***" >>$seqres.full > > > + _mount >>$seqres.full > > > + echo "*** end mount output" >>$seqres.full > > > + elif [ "$type" = "xfs" ]; then > > > + _mount_or_remount_rw "$extra_mount_options" $device $mountpoint I looked at this more and I think that a "ok=$?" is missed here (_mount_or_remount_rw return 1 as success), both _check_generic_filesystem and _check_btrfs_filesystem do this. So if it passes the first $ok check then does this rw mount and sets $ok based on the mount result. I'll just add a "ok=$?" here. Thanks, Eryu > > > + fi > > > + > > > + if [ $ok -eq 0 ]; then > > > + status=1 > > > + if [ "$iam" != "check" ]; then > > > + exit 1 > > > + fi > > > + return 1 > > > + fi > > > > THese $ok -eq 0 cases can be combined. > > > > Cheers, > > > > Dave. > > -- > > Dave Chinner > > david@xxxxxxxxxxxxx > -- > To unsubscribe from this list: send the line "unsubscribe fstests" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
