Old btrfs qgroup test cases uses fix golden output numbers, which limits
the coverage since they can't handle mount options like compress or
inode_map, and cause false alert.
Introduce _btrfs_check_scratch_qgroup() function to check qgroup
correctness using "btrfs check --qgroup-report" function, which will
follow the way kernel handle qgroup and are proved very reliable.
Signed-off-by: Qu Wenruo <quwenruo@xxxxxxxxxxxxxx>
---
common/rc | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
diff --git a/common/rc b/common/rc
index 8c99306..35d2d56 100644
--- a/common/rc
+++ b/common/rc
@@ -3018,6 +3018,25 @@ _require_deletable_scratch_dev_pool()
done
}
+# We check if "btrfs check" support to check qgroup correctness
+# Old fixed golden output can cover case like compress and inode_map
+# mount options, which limits the coverage
+_require_btrfs_check_qgroup()
+{
+ _require_command "$BTRFS_UTIL_PROG" btrfs
+ output=$($BTRFS_UTIL_PROG check --help | grep "qgroup-report")
+ if [ -z "$output" ]; then
+ _notrun "$BTRFS_UTIL_PROG too old (must support 'check --qgroup-report')"
+ fi
+}
+
+_btrfs_check_scratch_qgroup()
+{
+ _require_btrfs_check_qgroup
+ $BTRFS_UTIL_PROG check --qgroup-report $SCRATCH_DEV 2>&1 |\
+ grep -E "Counts for qgroup.*are different"
+}
+
# We check for btrfs and (optionally) features of the btrfs command
_require_btrfs()
{
--
2.7.4
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
