On Wed, Nov 02, 2016 at 12:07:26PM +0800, Wang Xiaoguang wrote: > In original common/populate codes, we put _require_xfs_io_command "falloc" and > _require_xfs_io_command "fpunch" in the begin of common/populate, but it's > not appropriate, for fs, which does not support falloc and punch, will not > be able to use other helper functions in common/populate, so here I choose > to put _require_xfs_io_command "falloc" or "punch" in helper function which > really use falloc and fpunch. > > And xfs/120 uses fpunch, add _require_xfs_io_command "fpunch". > > Signed-off-by: Wang Xiaoguang <wangxg.fnst@xxxxxxxxxxxxxx> Thanks for the patch! But I noticed that the new patchset posted by Darrick recently removed "_require"s from common/populate too ([PATCH 2/9] populate: add _require_populate_commands to check for tools), and his subsequent patches depend on this update. So I think it's better to take Darrick's patch, rather than taking this one and forcing Darrick to rebase his whole patchset again. And patch 2 requires the movement of the "_require"s in common/populate, so I'm going to merge it after reviewing & applying Darrick's patchset (otherwise generic/256 won't run on filesystems that don't support fallocate(2), e.g. ext2/3). That means patch 2 won't be in the pull request this week either. Hopefully we can see it in next pr. Thanks, Eryu -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
