On Thu, Oct 20, 2016 at 03:50:46PM +0800, Qu Wenruo wrote: > Add cc to new xfs mail list. > > > At 10/20/2016 03:46 PM, Qu Wenruo wrote: > > Hi Darrick, xfs guys and btrfs guys. > > > > Although such question is quite late as reflink generic tests are in > > fstests for a long time, I'm still not sure what's the correct behavior > > for reflink len = 0. > > > > Test case generic/182 is causing different output between btrfs and xfs. > > > > For btrfs, dedupe will just return 0 and check nothing, while for xfs > > len == 0 means to check the whole file length. > > > > Both makes sense for me, for btrfs len = 0 behavior, it just follows > > read/write functions. > > And I assume xfs follows reflink behavior, when len is not specified, > > then reflink the length of src file. > > > > But since it's a generic test, we need to unify the behavior. > > > > So, which one is the standard and which document should we follow for > > such behavior definition? > > > > Thanks, > > Qu Hey, Qu, I brought this up a few months back here [1], and I think the conclusion was that consistency with clone (so the XFS behavior) was probably what we wanted. I just forgot to follow up and figure out if it would break any userspace programs in a way that mattered (I doubt it). 1: http://marc.info/?l=linux-btrfs&m=146828374631829&w=2 -- Omar -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
