On Tue, Oct 18, 2016 at 10:59:44AM +0800, Xiao Yang wrote: > We need to remove unused ${SCRATCH_DEV} when calling __populate_check_xfs_dir > because __populate_check_xfs_dir function has been rewritten by Darrick. Can you reference the commit that the relevant change was contained in, please? Darrick has made lots of changes - saying "fix something after Darrick changed something else" isn't very meaningful, especially when someone looks at the commit in a few years time. Instead, try something like this: ---- [PATCH] xfstests: remove the device parameter from __populate_check_xfs_dir In commit abcdef1234 ("rewrite the frobnozzle"), the need for callers to pass the device to populate into __populate_check_xfs_dir() was removed. We can now clean up all the callers by removing the device parameter." ---- Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html