On 16 Oct 2016, at 17:15, Dave Chinner wrote: > On Sun, Oct 16, 2016 at 06:18:13AM -0400, Benjamin Coddington wrote: >> On 16 Oct 2016, at 3:17, Christoph Hellwig wrote: >> >>> On Fri, Oct 14, 2016 at 06:28:37AM -0400, Benjamin Coddington wrote: >>>> On NFS, try to discover the allocation size for the exported filesystem. >>>> NFS st_blksize is optimized for the network, and will usually be much >>>> larger than the allocation size of the exported filesystem, which may >>>> trigger preallocation strategies in the exported filesystem causing the >>>> seek tests here to fail. >>> >>> Is there a reason not to use your new evidence-based check for all >>> file systems? >> >> Only that on the filesystems I've checked (ext4, xfs, btrfs, tmpfs) >> st_blksize is correct, so trying to discover it is unnecessary. > > As I've said previously, mount options (e.g. -o largeio) can change > what XFS reports in st_blksize such that it behaves like the NFS > client... Ok, I'll send a v2. Ben -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
