On Mon, Oct 17, 2016 at 10:01 AM, Amir Goldstein <amir73il@xxxxxxxxx> wrote: > On Mon, Oct 17, 2016 at 12:46 AM, Dave Chinner <david@xxxxxxxxxxxxx> wrote: >> On Sun, Oct 16, 2016 at 01:53:42PM +0300, Amir Goldstein wrote: >>> Try to run xfs_io for tests in group quick with command line >>> option -M which starts an idle thread before performing any io. >>> >>> The purpose of this idle thread is to test io from a multi threaded >>> process. With single threaded process, the file table is not shared >>> and file structs are not reference counted. >>> >>> In order to improve the chance of detecting file struct reference >>> leaks, we should run xfs_io commands with this option as much as >>> possible. >>> >>> Analysis of the effect of xfs_io -M on tests runtime showed that >>> it may lead to slightly longer run times in extreme cases (e.g +3s >>> for generic/132), but has a negligable effect on runtime of tests >>> among the 'quick' group (worst case +0.3s for generic/130). >>> >>> Therefore, we automatically add the -M flags only to tests in the >>> 'quick' group. >>> >>> Signed-off-by: Amir Goldstein <amir73il@xxxxxxxxx> >>> --- ... >> A couple of seconds of >> extra runtime here and there means nothing for a typical auto test >> run which can take hours to run.... >> > Just to follow up on the extra runtime. I did one auto test run at 1h42m without -i flag and then auto test run at 1h45m with -i flag I did not repeat several runs to reduce noise. If anyone thinks that difference is too expensive please shout. Amir. -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
