Re: [PATCH] generic/317: fixup grep for qa_user_id

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On 11 Oct 2016, at 6:42, Eryu Guan wrote:

> On Tue, Oct 11, 2016 at 06:26:38AM -0400, Benjamin Coddington wrote:
>> The grep for $qa_user_id can return more than one entry.
>>
>> Signed-off-by: Benjamin Coddington <bcodding@xxxxxxxxxx>
>> ---
>>  tests/generic/317 | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tests/generic/317 b/tests/generic/317
>> index 9d9499ba04dd..ddaa6b59afc5 100755
>> --- a/tests/generic/317
>> +++ b/tests/generic/317
>> @@ -61,7 +61,7 @@ _require_scratch
>>  _require_user
>>  _require_ugid_map
>>  _require_userns
>> -qa_user_id=`grep $qa_user /etc/passwd |awk -F: '{print $3}'`
>> +qa_user_id=`grep ^${qa_user}: /etc/passwd |awk -F: '{print $3}'`
>
> Hi Ben,
>
> I have a patch[1] to fix this too (in a different way), and it's in my
> last pull request[2] to Dave, though he hasn't pushed them to upstream
> yet. Does it work for you?

Yes, that'll work.  Sorry for missing it.

Ben
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux