On Mon, Oct 10, 2016 at 01:06:47PM +0800, Wang Xiaoguang wrote: > For btrfs, if compression is enabled, it may generate inline data for a > blocksize data range, this inline data is stored in fs tree, will not have > a individual extent, try to reflink this data range at a not-zero offset > will return EOPNOTSUPP, so here we disable inline data feature for btrfs. > > Signed-off-by: Wang Xiaoguang <wangxg.fnst@xxxxxxxxxxxxxx> > --- > tests/generic/175 | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/tests/generic/175 b/tests/generic/175 > index 964580c..b3f90dc 100755 > --- a/tests/generic/175 > +++ b/tests/generic/175 > @@ -50,6 +50,13 @@ rm -f "$seqres.full" > > echo "Format and mount" > _scratch_mkfs > "$seqres.full" 2>&1 > +# For btrfs, if compression is enabled, it may generate inline data for a > +# blocksize data range, this inline data is stored in fs tree, will not have > +# a individual extent, try to reflink this data range at a not-zero offset > +# will return EOPNOTSUPP, so here we disable inline data feature for btrfs. > +if [ "$FSTYP" = "btrfs" ]; then > + export MOUNT_OPTIONS="-o max_inline=0 $MOUNT_OPTIONS" > +fi Can we /please stop/ putting special case code like this in tests? This is an unsustainable and unmaintainable practice - it's making a mess of the test code. If there are specific mount options that needs to be avoided, then add an option to filter them out. e.g. something like this: _scratch_options_filter btrfs compress so that it removes any compression option from the btrfs mount/mkfs that is run for that test. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
