On Sat, Oct 08, 2016 at 01:36:10AM +1100, Dave Chinner wrote: > On Fri, Oct 07, 2016 at 03:00:42PM +0800, Wang Xiaoguang wrote: > > When enabling btrfs compression, original codes can not fill fs > > correctly, fix this. > > > > Signed-off-by: Wang Xiaoguang <wangxg.fnst@xxxxxxxxxxxxxx> > > --- > > tests/generic/171 | 4 +--- > > tests/generic/172 | 2 +- > > tests/generic/173 | 4 +--- > > tests/generic/174 | 4 +--- > > 4 files changed, 4 insertions(+), 10 deletions(-) > > > > diff --git a/tests/generic/171 b/tests/generic/171 > > index f391685..d2ae8e4 100755 > > --- a/tests/generic/171 > > +++ b/tests/generic/171 > > @@ -75,9 +75,7 @@ _cp_reflink $testdir/bigfile $testdir/clonefile > > sync > > > > echo "Allocate the rest of the space" > > -nr_free=$(stat -f -c '%f' $testdir) > > -touch $testdir/file0 $testdir/file1 Why remove this line which ensures that the inode we're going to use (file1) later in the test has been allocated /before/ we try to eat all the space? > > -_pwrite_byte 0x61 0 $((blksz * nr_free)) $testdir/eat_my_space >> $seqres.full 2>&1 > > +dd if=/dev/zero of=$testdir/eat_my_space >> $seqres.full 2>&1 Uh... isn't a bunch of zeroes just as compressible as 0x61? I suppose the point here is to write until write returns ENOSPC, since in btrfs land we can't assume that writing $nr blocks will use up at least that much space. Does XFS reflink still pass this test with this patch? > Please don't replace xfs_io writes using a specific data pattern > with dd calls that write zeros. Indeed, we don't use dd for new > tests anymore - xfs_io should be used. > > Write a function that fills all the remaining free space (one may > already exist) and call it in all these places. Yeah, there already are a few of these... --D > > Cheers, > > Dave. > -- > Dave Chinner > david@xxxxxxxxxxxxx > -- > To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
