Re: [PATCH] fstests: require scratch dev in tests using dm targets

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Thu, Sep 22, 2016 at 05:05:53PM +0800, Eryu Guan wrote:
> We build dm device on top of scratch dev so we require $SCRATCH_DEV
> to be a valid block device in _require_dm_target(). And we need to
> _require_scratch before _require_dm_target, otherwise test fails if
> there's no SCRATCH_DEV defined, where it should _notrun.
> 
>   +Usage: _require_block_device <dev>
> 
> So add _require_scratch_nocheck to generic/347 (we do the fs check
> on thinp device), move _require_scratch before _require_dm_target in
> xfs/006 and xfs/264.
> 
> Signed-off-by: Eryu Guan <eguan@xxxxxxxxxx>

Looks good.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux