Re: [PATCH] generic/159: record error value correctly

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Tue, Aug 30, 2016 at 11:51:14AM +0800, Wang Xiaoguang wrote:
> This case failed in btrfs, it's because when trying to open an immutable
> file, vfs returns EPERM, not EACCESS, fix this.
> 
> Signed-off-by: Wang Xiaoguang <wangxg.fnst@xxxxxxxxxxxxxx>
> ---
>  tests/generic/159.out | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/generic/159.out b/tests/generic/159.out
> index 92fe33a..3e5e47f 100755
> --- a/tests/generic/159.out
> +++ b/tests/generic/159.out
> @@ -2,4 +2,4 @@ QA output created by 159
>  Format and mount
>  Create the original files
>  Try reflink on immutable files
> -TEST_DIR/test-159/file2: Permission denied
> +TEST_DIR/test-159/file2: Operation not permitted

I think you need to do a filter in the test not change the golden image,
so older kernels won't fail because they still return EACCES on
immutable inodes.

Thanks,
Eryu
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux