On Wed, Aug 17, 2016 at 5:36 AM, Eryu Guan <eguan@xxxxxxxxxx> wrote: >> _mkfs_validation_check() >> { >> + if [ ! -f /tmp/foo ]; then >> + touch /tmp/foo >> + fi > > I think the file can be touched unconditionally. > If the file already exists and mtime/atime of the file is important, then it could be an issue. It looks improbable, but still, maybe we should be on the safe side? Anyway, thanks for spotting this. Jan -- Jan Tulak jtulak@xxxxxxxxxx / jan@xxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html