On Thu 21-07-16 09:35:07, Jan Kara wrote:
> On Thu 21-07-16 14:55:26, Eryu Guan wrote:
> > On Thu, Jul 21, 2016 at 08:17:36AM +0200, Jan Kara wrote:
> > > On my test setup xfs_io reports 'nan' in bytes/s and ops/s fields when
> > > the operation takes zero time. Account for that in _filter_xfs_io.
> > >
> > > Signed-off-by: Jan Kara <jack@xxxxxxx>
> > > ---
> > > common/filter | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/common/filter b/common/filter
> > > index b229a97dfa0e..37f07c8ca1ac 100644
> > > --- a/common/filter
> > > +++ b/common/filter
> > > @@ -221,7 +221,7 @@ common_line_filter()
> > >
> > > _filter_xfs_io()
> > > {
> > > - sed -e "s/[0-9/.]* [GMKiBbytes]*, [0-9]* ops\; [0-9/:. sec]* ([inf0-9/.]* [EPGMKiBbytes]*\/sec and [inf0-9/.]* ops\/sec)/XXX Bytes, X ops\; XX:XX:XX.X (XXX YYY\/sec and XXX ops\/sec)/"
> > > + sed -e "s/[0-9/.]* [GMKiBbytes]*, [0-9]* ops\; [0-9/:. sec]* ([infnan0-9/.]* [EPGMKiBbytes]*\/sec and [infnan0-9/.]* ops\/sec)/XXX Bytes, X ops\; XX:XX:XX.X (XXX YYY\/sec and XXX ops\/sec)/"
> >
> > Seems adding only 'a' to the char set is sufficient, 'n' is already in
> > the set, i.e.
> >
> > - ...([inf0-9/.]* ...
> > + ...([infa0-9/.]* ...
>
> Yeah. I've added 'nan' to document what the letters are there for. But
> probably I should have added just 'a' and added a comment. I'll respin the
> patch.
Attached is a revised patch.
Honza
--
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR
>From 8d86c6fe36040e21db3475292a2dd05a280f158f Mon Sep 17 00:00:00 2001
From: Jan Kara <jack@xxxxxxx>
Date: Thu, 21 Jul 2016 08:15:19 +0200
Subject: [PATCH] generic/130: Improve xfs_io filter
On my test setup xfs_io reports 'nan' in bytes/s and ops/s fields when
the operation takes zero time. Account for that in _filter_xfs_io.
Signed-off-by: Jan Kara <jack@xxxxxxx>
---
common/filter | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/common/filter b/common/filter
index b229a97dfa0e..f80cd562af71 100644
--- a/common/filter
+++ b/common/filter
@@ -221,7 +221,9 @@ common_line_filter()
_filter_xfs_io()
{
- sed -e "s/[0-9/.]* [GMKiBbytes]*, [0-9]* ops\; [0-9/:. sec]* ([inf0-9/.]* [EPGMKiBbytes]*\/sec and [inf0-9/.]* ops\/sec)/XXX Bytes, X ops\; XX:XX:XX.X (XXX YYY\/sec and XXX ops\/sec)/"
+ # Apart from standard numeric values, we also filter out 'inf' and 'nan'
+ # which can result from division in some cases
+ sed -e "s/[0-9/.]* [GMKiBbytes]*, [0-9]* ops\; [0-9/:. sec]* ([infa0-9/.]* [EPGMKiBbytes]*\/sec and [infa0-9/.]* ops\/sec)/XXX Bytes, X ops\; XX:XX:XX.X (XXX YYY\/sec and XXX ops\/sec)/"
}
_filter_xfs_io_unique()
--
2.6.6
