On Tue, Jun 28, 2016 at 09:32:55PM -0400, Theodore Ts'o wrote: > Teach _require_odirect to skip the O_DIRECT tests if the ext4 mount > option "test_dummy_encryption" is enabled, since O_DIRECT doesen't > make sense when file system level encryption is enabled, and several > tests which use O_DIRECT --- ext4/301, ext4/304, generic/250 and > generic/252 --- fail when encryption is enabled. Stupid question: why isn't ext4 simply falling back to buffered IO when encryption is enabled on a file? This seems kind of strange to have direct IO conditionally supported based on mkfs/mount parameters (or perhaps even per-file configurations).... Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
