Re: [PATCH v2] xfstests: Fix installation for extended names

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Thu, Jun 30, 2016 at 05:19:53PM +0200, Jan Tulak wrote:
> On Thu, Jun 30, 2016 at 3:33 PM, Eryu Guan <eguan@xxxxxxxxxx> wrote:
> > On Thu, Jun 30, 2016 at 10:35:10AM +0200, Jan Tulak wrote:
> >> xfstests supports extended test names like 314-foo-bar, but installation of
> >> these tests was skipped (not matching a regexp). So this patch fixes the
> >> makefiles in tests directories.
> >>
> >> Signed-off-by: Jan Tulak <jtulak@xxxxxxxxxx>
> >> ---
> >> UPDATE:
> >>   * install failed when no extended name was present, so suppress errors for
> >>     extended names
> >
> > Hmm, this looks ugly to me :) I was thinking about it too, but didn't
> > work out a better idea. Now I tend to add this installation support to
> > tests/xfs/Makefile only, and we can add the support to other tests when
> > needed. What do you think?
> >
> 
> Yeah. I thought about better regexp, but unfortunately, whatever sh
> Make uses, it has just limited support for that, unlike bash. So, yes,
> add it for xfs tests only... Should I send another patch for that?

Yes, please. Thanks!

Eryu
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux