On Thu, Jun 30, 2016 at 5:38 AM, Eryu Guan <eguan@xxxxxxxxxx> wrote: > On Wed, Jun 29, 2016 at 04:57:55PM +0200, Jan Tulak wrote: >> xfstests supports extended test names like 314-foo-bar, but installation of >> these tests was skipped (not matching a regexp). So this patch fixes the >> makefiles in tests directories. >> >> Signed-off-by: Jan Tulak <jtulak@xxxxxxxxxx> > > Thanks for fixing it! But this breaks installation in other subdirs > > # make install > ... > ../../install-sh -o root -g root -m 755 [0-9]??-* /var/lib/xfstests/tests/btrfs > cp: cannot stat ‘[0-9]??-*’: No such file or directory > gmake[2]: *** [install] Error 1 > gmake[1]: *** [/root/xfstests/tests/btrfs/-install] Error 2 > make: *** [tests-install] Error 2 > Hmm, yeah, I see... It fails when there is no such file to install. I'm making it to ignore the error in the way: -$(INSTALL) -m 755 [0-9]??-* $(TARGET_DIR) 2>/dev/null;true It might hide some other issues (permissions...), but the chances are, if something goes wrong, it goes wrong also with the standard three-digit-names, where the error is not suppressed. Thanks, Jan -- Jan Tulak jtulak@xxxxxxxxxx / jan@xxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
