On Wed, Jun 29, 2016 at 2:52 PM, Eryu Guan <eguan@xxxxxxxxxx> wrote: > On Wed, Jun 29, 2016 at 12:38:13PM +0200, Jan Tulak wrote: >> mkfs.xfs does not do a very good job of input validation. This test >> is designed to exercise the input validation and test good/bad >> combinations of options being set. It will not pass on an old >> mkfs.xfs binary - it is designed to be the test case for an input >> validation cleanup (merged in spring/summer 2016). >> >> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx> >> Signed-off-by: Jan Tulak <jtulak@xxxxxxxxxx> >> >> --- >> >> I didn't got other feedback than the three small issues fixed bellow, and it is >> passing on current xfsprogs-dev as it should. So I think that it can be merged. > > Looks good to me. > >> >> CHANGES: >> * Change copyright year to 2016 >> * rm || true --> rm -f >> * Change from space to tab indent >> >> Cheers, >> Jan >> >> Signed-off-by: Jan Tulak <jtulak@xxxxxxxxxx> >> --- >> tests/xfs/400-input-validation | 335 +++++++++++++++++++++++++++++++++++++ >> tests/xfs/400-input-validation.out | 2 + > > Only one problem with this test seq name. Current Makefile doesn't > support installing such test seq name > > $(INSTALL) -m 755 [0-9]?? $(TARGET_DIR) > > Can you please send another patch to fix this? > O_o Looks like I forgot the installation part when I was writing the patches for xfstests for the extended test names. Gonna fix it! Thanks. Cheers, Jan -- Jan Tulak jtulak@xxxxxxxxxx / jan@xxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
