On Tue, Jun 21, 2016 at 06:40:28PM +0800, Eryu Guan wrote: > Some tests require that there's no certain mount option, so > introduce a new helper _require_no_mount_opts() to do the check on > $MOUNT_OPTIONS. I think this is fine, except for the name. It's more of an exclude rule rather than a "require" rule. i.e. _exclude_mount_option() is closer to it's purpose. The only other question I have is that mount options can be different between test and scratch devices - the test device mount options can be set via TEST_FS_MOUNT_OPTS, as well as via MOUNT_OPTIONS. Does this rule need to handle that? Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
