[PATCH] ext4/271: Fix test failure with data=<foo> mount option

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



The test is failing when MOUNT_OPTIONS contain 'data=<foo>' mount option
as it does not combine with 'noload' mount option the test uses. Fix it
by removing the data=<foo> mount option. Arguably we could also fix the
problem by just skipping the test when such option is set but e.g. using
'data=writeback' is common to excercise somewhat different behavior and
it is undesirable to skip the test just because of this.

Signed-off-by: Jan Kara <jack@xxxxxxx>
---
 tests/ext4/271 | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tests/ext4/271 b/tests/ext4/271
index d68c2719024e..417a796ffac9 100755
--- a/tests/ext4/271
+++ b/tests/ext4/271
@@ -45,6 +45,10 @@ _scratch_mkfs_sized $((128 * 1024 * 1024)) >> $seqres.full 2>&1
 
 # -onoload and EXT4_SYNC_FL on file is important becase result in
 # metadata sync writes inside ext4_handle_dirty_metadata()
+#
+# We have to be careful and remove data=<foo> mount options as they don't
+# combine with 'noload'.
+MOUNT_OPTIONS=$(echo $MOUNT_OPTIONS | sed -e 's/\([ ,]\)data=[a-zA-Z]*[,$]/\1/')
 _scratch_mount -onoload
 touch $SCRATCH_MNT/file
 $CHATTR_PROG +S $SCRATCH_MNT/file
-- 
2.6.6

--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux