On Wed, Jun 15, 2016 at 01:21:31PM +0800, Guangwen Feng wrote: > Commit c9eb13a fixed this bug: > ext4: fix hang when processing corrupted orphaned inode list Unfortunately, I don't know what this bug is, or what the test is actually doing from this description or from reading the actual test. Please assume that not just the reviewer but someone reading this description 5 yers from now knows *nothing* about the problem the test addresses. Hence the patch description needs to explain more fully what the problem is that the test is exercising.... It's also unfortunate that kernel tree commits are being referenced without saying what tree they belong to. i.e. this should read "kernel commit ab1234cd" so we know that commit is not something from the fstests tree, or e2fsprogs, or some other unknown tree. Again - think about someone reading this in 5 years time and trying to work out what it means... Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
