Hi, Eryu. Thanks for your review and kindly reply! On 06/15/2016 11:35 AM, Eryu Guan wrote: > On Tue, Jun 14, 2016 at 12:39:42PM +0800, Eryu Guan wrote: >> On Tue, Jun 14, 2016 at 10:58:59AM +0800, Guangwen Feng wrote: >>> Commit c9eb13a fixed this bug: >>> ext4: fix hang when processing corrupted orphaned inode list >>> >>> Signed-off-by: Guangwen Feng <fenggw-fnst@xxxxxxxxxxxxxx> >> >> Looks good to me overall. Some minor issues inline below >> > [snip] >> >>> + debugfs -w -R "ssv last_orphan $i" $SCRATCH_DEV >>$seqres.full 2>&1 >> >> You defined $DEBUGFS_PROG, use it here :) >> >>> + _scratch_mount >>> + _scratch_unmount >> >> There's a new helper to do this now, _scratch_cycle_mount > > Sorry, the helper doesn't help here, it umount first then mount. You're > doing mount then umount. Got it. I was just writing to explain this actually. :) Thanks again. > > Thanks, > Eryu > > > -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
