On Sat, Jun 11, 2016 at 08:20:26PM +0800, Eryu Guan wrote: > > This hunk doesn't apply, there's no detection code for ext4 encryption > in current master. And do we need to filter out ext3 journal mode as > well? Oops, there's another patch this depends upon that I forgot to send out this time around. Let me fix up the spaces and tabs, and probably just combine the two patches. > Just curious, what's the problem running direct I/O tests on journal > mode ext4? ext4 falls back to buffered I/O in this case and I don't see > any test failures caused by it. Perhaps it'd be better to add this > information to commit log too. I'll double check but I think there was at least one dmflaky that failed (or maybe it was just flaky) because the DIO write wasn't really DIO, and if the device went read-only too early, the data write wouldn't make it to the disk, and this caused the test failure. More generally, if a particular file system mode doesn't support Direct I/O, even if it doesn't cause a test failure, it's likely a waste of test resources to run a test which expected that writes be DIO when it really isn't. - Ted -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
