A comment in shared/277 claims that ext4 supports O_DIRECT in data=journalling mode. Actually, it doesn't, it was just silently ignoring O_DIRECT, let's not try to test O_DIRECT for either ext3 or ext4 in this test. Signed-off-by: Theodore Ts'o <tytso@xxxxxxx> --- tests/shared/272 | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/tests/shared/272 b/tests/shared/272 index e5adf38..df1366a 100755 --- a/tests/shared/272 +++ b/tests/shared/272 @@ -31,10 +31,8 @@ tmp=/tmp/$$ status=1 # failure is the default! trap "rm -f $tmp.*; exit \$status" 0 1 2 3 15 -# ext3 doesn't support direct IO in journalling mode +# ext3 and ext4 doesn't support direct IO in journalling mode write_opt_list="iflag=noatime conv=notrunc conv=fsync" -# For filesystems that can handle it, add also direct IO test -[ $FSTYP = "ext4" ] && write_opt_list="$write_opt_list oflag=direct" # get standard environment, filters and checks . ./common/rc -- 2.5.0 -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
