Re: [PATCH] fstests: fix various $seqres.full issues

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Wed, May 04, 2016 at 06:37:57PM +0800, Eryu Guan wrote:
> There're many tests don't remove $seqres.full before writing to it, and
> accumulating logs there, then the logs are always growing over time.
> Let's fix them once.
> 
> generic/16[1-8] generic/170 and generic/33[34] truncate $seqres.full in
> the middle of the test, which results in partial logs. Fix them as well.
> 
> xfs/227 has duplicated lines to remove $seqres.full, remove the extra
> line.
.....
> diff --git a/tests/xfs/261 b/tests/xfs/261
> index 950c539..962f6fc 100755
> --- a/tests/xfs/261
> +++ b/tests/xfs/261
> @@ -51,6 +51,7 @@ _cleanup()
>  . ./common/quota
>  
>  echo "Silence is golden."
> +rm -r $seqres.full
      ^^

I think you meant rm -f. Test fails when $seqres.full doesn't
exist...

I've fixed it up.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux