On Mon, Mar 14, 2016 at 10:24:30AM -0700, Darrick J. Wong wrote: > On Mon, Mar 14, 2016 at 03:56:47PM +0800, Qu Wenruo wrote: > > Please don't merge this patchset. > > > > As the there is some naming undecided recently. > > > > The abbreviation 'dedup' may be changed to 'dedupe'. > > I'll update them when all related parts is settled down. > > There's already a 'dedupe' group in xfstests for testing the out-of-band ioctl > that duperemove uses. I wondered if that factored into your decision to use > 'dedup' as the group name for the inband tests. > > Seeing as other filesystems are beginning to support the OOB ioctls and might > never support the in-band stuff btrfs is doing, what do people think about > keeping the out-of and in-band dedup tests in separate groups to make it clear > which dedupe feature each test is aiming to validate? So just name the two groups appropriately: "ib-dedupe" and "oob-dedupe" or something like that. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
