On Wed, Feb 24, 2016 at 01:42:08PM +0100, David Sterba wrote: > On Fri, Feb 19, 2016 at 09:25:28PM +0800, Anand Jain wrote: > > This patch fixes test btrfs/011 which intended to use -r option > > but was never used since its associated args 'replace_options' > > didn't make it to the cli. > > After this patch the tests fails due to extra output. I've tested > several kernels (4.5 rcs), HDD and SSD so it's not caused by my testing > setup. I'll use this as an opportunity to point out that nobody is reviewing most btrfs test changes. I'll commit the changes if no-one says anything about them, they look sane to me and don't cause me any problems, but that doesn't mean they will work. Mostly I'm concerned about changes to the common code and code patterns, not what the test does or whether it is even a valid test. IOWs, it is up to the developers who use xfstests to make sure the tests relevant to their areas of expertise work correctly and are valid/viable tests, not me. To avoid this sort of issue in future, please review changes promptly. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
