----- 原始邮件 ----- > 发件人: "Dave Chinner" <david@xxxxxxxxxxxxx> > 收件人: "Zorro Lang" <zlang@xxxxxxxxxx> > 抄送: fstests@xxxxxxxxxxxxxxx, eguan@xxxxxxxxxx > 发送时间: 星期五, 2016年 2 月 19日 上午 9:33:16 > 主题: Re: [PATCH] xfs: change return value check to golden image check > > On Fri, Feb 12, 2016 at 12:37:36AM +0800, Zorro Lang wrote: > > xfs/133 and xfs/138 use too much code to do "return value" check, > > it's not necessary. For the code can be more readable and clear, > > I change "return value" check to golden image check. > > > > Signed-off-by: Zorro Lang <zlang@xxxxxxxxxx> > > --- > > tests/xfs/133 | 20 +++++++------------- > > tests/xfs/133.out | 7 +++++++ > > tests/xfs/138 | 26 ++++++++++++-------------- > > tests/xfs/138.out | 12 ++++++++++++ > > 4 files changed, 38 insertions(+), 27 deletions(-) > > This cause a xfs/133 failure like this on my systems: > > --- tests/xfs/133.out 2016-02-19 10:40:57.043131919 +1100 > +++ /home/dave/src/xfstests-dev/results//xfs/xfs/133.out.bad 2016-02-19 > 12:24:53.173589432 +1100 > @@ -4,5 +4,6 @@ > Filesystem Blocks Quota Limit Warn/Time Mounted on > SCRATCH_DEV 0 102400 204800 00 [--------] SCRATCH_MNT > === report command output === > +(null) 0 0 0 00 [--------] > 123456-project 0 102400 204800 00 [--------] > > > Can you see if you can reproduce it? Hi Dave, Thanks for review this patch:) I can't reproduce that problem. It shows xfs_quota report one more strange line, I can't sure what cause it by read xfs/133. xfs/133 only set one project quota for 123456-project, I don't think it will report one more project quota message. I can add 'grep 123456-project' to make sure it will only report 123456-project. But I can't do that before I sure that problem you met is not a xfsprogs bug. So would you please give me more information about your test environment, especially about xfs project quota? I will do more exception test, try to reproduce it. Thanks, Zorro Lang > > Cheers, > > Dave. > -- > Dave Chinner > david@xxxxxxxxxxxxx > -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
