Re: [PATCH 12/16] xfstests: remove dependency on /proc/partitions for generic/312

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Wed, Feb 17, 2016 at 02:06:03AM -0800, Christoph Hellwig wrote:
> > +# We don't need to do this check for tmpfs because _scratch_mkfs_size
> > +# will validate the size against the available memory
> > +if [ "$FSTYP" != "tmpfs" ]; then
> > +   _scratch_mkfs
> > +   _scratch_mount
> > +   _require_fs_space $SCRATCH_MNT $(($fssize / 1024))
> > +   _scratch_unmount
> > +fi
> >  rm -f $seqres.full
> >  _scratch_mkfs_sized $fssize >>$seqres.full 2>&1
> 
> _scratch_mkfs_size also validates the available space for other
> block based file systems, so I think we should just remove this
> code entirely (assuming I didn't miss something important)

I agreed, not sure why I wrote this check in the first place..

Thanks,
Eryu
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux