On Thu, Feb 11, 2016 at 12:56:13AM -0500, Theodore Ts'o wrote: > Dave Chinner has pointed out this test is largely pointless: > > Perhaps one should question whether generic/125 is actually testing > anything useful in the first place. > > i.e. it's writing 16k, then truncating it back to 1000 bytes, then > reading it with direct IO for 60s to see if it returns the correct > data for that entire time. > > What, exactly, is going to cause that test to fail? > > Keep in mind this was ported from a CXFS test, where the metadata > server did the truncation operation (including the data zeroing), > but the reads are being done from the client. i.e. it was designed > to test whether a remote machine is doing a truncate correctly on a > access shared disk. > > IMO, I think we just remove the test, src/trunc.c and src/ftrunc.c > because it's 60s of testing that doesn't actually provide any value > to us. > > Signed-off-by: Theodore Ts'o <tytso@xxxxxxx> > --- > tests/generic/125 | 68 ----------------------------------------------------- > tests/generic/group | 1 - > 2 files changed, 69 deletions(-) > delete mode 100755 tests/generic/125 Also remove 125.out ? Thanks, Eryu -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
