On Wed, Feb 10, 2016 at 06:39:11PM -0500, Theodore Ts'o wrote: > On Wed, Feb 10, 2016 at 04:54:55PM +1100, Dave Chinner wrote: > > > > _scratch_mkfs > > _scratch_mount > > _require_fs_space $SCRATCH_MNT $((fssize / 1024)) > > _scratch_unmount > > _scratch_mkfs_sized $fssize > > This doesn't work because _require_fs_space uses df -klP, and the -l > file systems with names such as "test:/scratch" to be filtered out --- > and xfstests requires us to use NFS-looking names as a hint that the > file system has no block device. > > This results in "_require_fs_space" failing on tmpfs file systems with > the error messages: > > df: no file systems processed > ./common/rc: line 1860: [: -lt: unary operator expected > > I'm not sure why the -l option is being used at all in the first > place. Any objections if I remove it? Presumably this is also > causing _require_fs_space to blow up on any tests run using NFS.... No idea on why -l is used. If there is a reason to be found, it will be in the commit history. > Alternatively I could just remove if it $FSTYP == tmpfs, but that > assumes there was some reason for using the -l option in the first > place. Remove it, see what breaks/who complains. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
