On Wed, Feb 10, 2016 at 11:11:35AM -0500, Theodore Ts'o wrote: > On Wed, Feb 10, 2016 at 05:15:13PM +0800, Eryu Guan wrote: > > > > generic/125 only runs "./src/ftrunc" and I don't see where O_DIRECT is > > being used, did I miss anything? > > generic/125 also calls "src/trunc", which does use O_DIRECT. > > (Hmm, and it assumes '.' is in the test's path, which I don't think is > a safe thing to do.) Perhaps one should question whether generic/125 is actually testing anything useful in the first place. i.e. it's writing 16k, then truncating it back to 1000 bytes, then reading it with direct IO for 60s to see if it returns the correct data for that entire time. What, exactly, is going to cause that test to fail? Keep in mind this was ported from a CXFS test, where the metadata server did the truncation operation (including the data zeroing), but the reads are being done from the client. i.e. it was designed to test whether a remote machine is doing a truncate correctly on a access shared disk. IMO, I think we just remove the test, src/trunc.c and src/ftrunc.c because it's 60s of testing that doesn't actually provide any value to us. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
