On Wed, Feb 10, 2016 at 05:07:16PM +1100, Dave Chinner wrote: > > # Remounting with nodiratime option > > -_scratch_unmount > > -_scratch_mount "-o nodiratime" > > +_scratch_remount "-o nodiratime" > > This makes me go "no, that can't work, nodiratime is not an option > that we allow on remount." Hmm, yes, we're not consistent here. xfs doesn't allow nodiratime on remounts. ext4 allows nodiratime on remount, but not diratime, so there's no way to clear nodiratime once its set. tmpfs allows diratime and nodiratime on remount. I wonder if it's worth it make things more consistent across the various file systems. What do you think? > So, at minimum, the name of the helper needs to get changed so that > it doesn't imply that a "-o remount" with new options is being > done... Hmm, how about having two helper functions: _scratch_remount that doesn't take any arguments, and a _scratch_change_mount_opts which does? > > -_umount_mount > > +_scratch_mkfs >/dev/null 2>&1 || _fail "mkfs failed" > > +_scratch_mount > /dev/null 2>&1 || _fail "mount failed" > > Please don't add _fail to mkfs/mount like this, especially where the > test doesn't already have them. Could you say more about why? We do have tests that do use _fail if the mkfs or mount fails. Should we be changing them to remove it? But if we do that, and the mount fails for some reason, then won't things stagger on and perhaps make life harder to debug. Cheers, - Ted -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
