Re: [PATCH V2] xfs/242: remove open-coded check for "zero" command

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Fri, Dec 04, 2015 at 04:02:14PM -0600, Eric Sandeen wrote:
> We have helpers for this, no need to open-code it.
> 
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>

Reviewed-by: Eryu Guan <eguan@xxxxxxxxxx>

> ---
> 
> v2: clarify subject w/ "xfs/242"
> 
> diff --git a/tests/xfs/242 b/tests/xfs/242
> index 304e69f..4e1a8b4 100755
> --- a/tests/xfs/242
> +++ b/tests/xfs/242
> @@ -47,14 +47,7 @@ _supported_fs xfs
>  _supported_os Linux
>  _require_test
>  
> -_test_io_zero()
> -{
> -	$XFS_IO_PROG -c "zero help" 2>&1 | \
> -			grep 'command "zero" not found' > /dev/null
> -	echo $?
> -}
> -
> -[ $(_test_io_zero) -eq 0 ] && _notrun "zero command not supported"
> +_require_xfs_io_command "zero"
>  
>  testfile=$TEST_DIR/242.$$
>  
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe fstests" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux