Hi, Dave Chinner > -----Original Message----- > From: Dave Chinner [mailto:david@xxxxxxxxxxxxx] > Sent: Tuesday, December 08, 2015 6:12 AM > To: Zhaolei <zhaolei@xxxxxxxxxxxxxx> > Cc: fstests@xxxxxxxxxxxxxxx; linux-btrfs@xxxxxxxxxxxxxxx > Subject: Re: [PATCH] fstests: Fix generic/102 fail for btrfs > > On Thu, Dec 03, 2015 at 06:08:36PM +0800, Zhaolei wrote: > > From: Zhao Lei <zhaolei@xxxxxxxxxxxxxx> > > > > generic/102 sometimes fails in newest btrfs toolchain, because it use > > non-mixed mode in default, which request more space for metadata, and > > no space for data writing. > > > > This patch force mixed mode for btrfs in generic/102. > > > > Signed-off-by: Zhao Lei <zhaolei@xxxxxxxxxxxxxx> > > --- > > tests/generic/102 | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/tests/generic/102 b/tests/generic/102 index > > abc3994..8c01fb5 100755 > > --- a/tests/generic/102 > > +++ b/tests/generic/102 > > @@ -48,6 +48,8 @@ _require_scratch > > > > rm -f $seqres.full > > > > +[[ "$FSTYP" = "btrfs" ]] && MKFS_OPTIONS+=" --mixed" > > + > > dev_size=$((512 * 1024 * 1024)) # 512MB filesystem > > _scratch_mkfs_sized $dev_size >>$seqres.full 2>&1 > > This sort of filesystem size specific mkfs requirement belongs in the filesystem > specific section of _scratch_mkfs_sized(). > Thanks for review. Agree with you in generic, but for this case, if we changes to use --mixed mode in _scratch_mkfs_sized() for all btrfs, xfstests will not able to check non-mixed mode of btrfs, which is more popular for real-world users. So we only use --mixed mode for btrfs in generic/102 will be a better choice. And similar way also exist in some tests of current xfstests: generic/204:[ $FSTYP = "xfs" ] && MKFS_OPTIONS="$MKFS_OPTIONS -l size=7m -i maxpct=50" generic/040:if [ "$FSTYP" = "btrfs" ]; then _scratch_mkfs "-O extref" >> $seqres.full 2>&1 generic/041:if [ "$FSTYP" = "btrfs" ]; then _scratch_mkfs "-O extref" >> $seqres.full 2>&1 ... Thanks Zhaolei > Cheers, > > Dave. > -- > Dave Chinner > david@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
