Re: [patch] fstests: remove generic/042 from the 'auto' group

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Wed, Dec 02, 2015 at 01:28:22PM -0500, Jeff Moyer wrote:
> Hi,
> 
> This test fails 100% of the time for me on xfs and current git head, and
> is not run for ext4 since ext4 does not support shutdown.  After talking
> with bfoster, it isn't expected to succeed right now.  Since the auto
> group is for tests that *are* expected to succeed, let's move this one
> out.
> 
> Signed-off-by: Jeff Moyer <jmoyer@xxxxxxxxxx>
> 

My recollection for this test was that Dave had described the delalloc
extent -> real extent stale data exposure issue and I had a thought on
how to reproduce it based on some work I was doing on the zero range
bits around that time. That happened to prove effective, so I wanted to
get the test included before I lost track of it (even though a real fix
wasn't yet available).

I had played with fixing this a bit before. IIRC, it's potentially
affected by some of the work to kill buffer_head usage in the writepages
path, so I might revisit it once that stuff is more fleshed out. Until
then, this seems reasonable to me:

Reviewed-by: Brian Foster <bfoster@xxxxxxxxxx>

> diff --git a/tests/generic/group b/tests/generic/group
> index a33536e..4b70008 100644
> --- a/tests/generic/group
> +++ b/tests/generic/group
> @@ -44,7 +44,7 @@
>  039 metadata auto quick
>  040 metadata auto quick
>  041 metadata auto quick
> -042 auto quick rw
> +042 quick rw
>  043 metadata log auto
>  044 metadata log auto
>  045 metadata log auto
> --
> To unsubscribe from this list: send the line "unsubscribe fstests" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux