Re: [PATCH] fstests: test for btrfs incremental send after replacing a file

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Tue, Sep 29, 2015 at 09:33:34AM +0100, Filipe Manana wrote:
> On Tue, Sep 29, 2015 at 4:54 AM, Eryu Guan <eguan@xxxxxxxxxx> wrote:
> > On Sat, Sep 26, 2015 at 12:40:13PM +0100, fdmanana@xxxxxxxxxx wrote:
> >> From: Filipe Manana <fdmanana@xxxxxxxx>
> >>
> >> Test that an incremental send works after a file from the parent snapshot
> >> gets replaced in the send snapshot by another one at the same exact
> >> location, with the same name and with the same inode number.
> >>
> >> This test used to fail after the linux kernel commit 8b191a684968
> >> ("Btrfs: incremental send, check if orphanized dir inode needs delayed
> >> rename") and it's fixed by patch titled:
> >>
> >>   "Btrfs: send, fix corner case for reference overwrite detection"
> >
> > I got "btrfs receive" error when testing this, with 4.3-rc1 kernel and
> > btrfs-progs v4.2, not sure if this is expected
> 
> Yes, it's expected.
> The fix isn't yet in any kernel release (nor rc).

Thanks for the clarification, I was somehow expecting a file md5 mismatch.

Then the patch looks good to me.

Reviewed-by: Eryu Guan <eguan@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux