[PATCH] xfs/201: use min_dio_alignment size to replace 512b

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



This case use hard-code 512, but in 4k sector size device,
it will fail.

So I call _min_dio_alignment() to get the sector size, then
replace `512`.

Signed-off-by: Zorro Lang <zlang@xxxxxxxxxx>
---
 tests/xfs/201 | 20 +++++++++++---------
 1 file changed, 11 insertions(+), 9 deletions(-)

diff --git a/tests/xfs/201 b/tests/xfs/201
index 88829d3..921d2a3 100755
--- a/tests/xfs/201
+++ b/tests/xfs/201
@@ -32,15 +32,6 @@ here=`pwd`
 tmp=/tmp/$$
 status=1	# failure is the default!
 
-do_pwrite()
-{
-	offset=`expr $1 \* 512`
-	end=`expr $2 \* 512`
-	length=`expr $end - $offset`
-
-	xfs_io -d -f $file -c "pwrite $offset $length" >/dev/null
-}
-
 _cleanup()
 {
 	umount $SCRATCH_MNT
@@ -57,6 +48,17 @@ _supported_os Linux
 
 file=$SCRATCH_MNT/f
 
+min_align=`_min_dio_alignment $SCRATCH_DEV`
+
+do_pwrite()
+{
+	offset=`expr $1 \* $min_align`
+	end=`expr $2 \* $min_align`
+	length=`expr $end - $offset`
+
+	xfs_io -d -f $file -c "pwrite $offset $length" >/dev/null
+}
+
 _require_scratch
 
 _scratch_mkfs_xfs >/dev/null 2>&1
-- 
1.9.3

--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux