On Fri, Aug 14, 2015 at 12:16:32AM +0800, Zorro Lang wrote: > generic/084 try to run 'tail' command, tail will use > inotify, and there're some limit about inotify. I think > the most important is fs.inotify.max_user_instances, then > fs.inotify.max_user_watches is importand too. max_user_watches is much larger (usually 8k?) than max_user_instances (128), I think we can skip the max_user_watches check here. > > When I test on a machine with 154 cpu cores, this case > run failed, and hit many warning likes: > > tail: inotify cannot be used, reverting to polling: Too many > open files No need to wrap lines for quoted logs. > > Because the fs.inotify.max_user_instances is 128, so if > we try to tail 154 files, it will be failed. > > Of course, open files limit will effect this too. But generally > max_user_instances is the minimum number, so I don't check open > file limit. > > Signed-off-by: Zorro Lang <zlang@xxxxxxxxxx> > --- > tests/generic/084 | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/tests/generic/084 b/tests/generic/084 > index 3fec6c2..f34d4b2 100755 > --- a/tests/generic/084 > +++ b/tests/generic/084 > @@ -63,6 +63,15 @@ link_unlink_storm() > > rm -f $seqres.full > nr_cpu=`$here/src/feature -o` > +user_watches=`sysctl -n fs.inotify.max_user_watches` > +user_instances=`sysctl -n fs.inotify.max_user_instances` I think we need some comments in the code too. > + > +user_limit=$((user_watches > user_instances ? user_instances : user_watches)) Please use plain if:then > +if [ $nr_cpu -ge $((user_limit/2)) ] > +then if []; then fi this is the preferred format in xfstests > + nr_cpu=$((user_limit/2)) Need comments to explain why divide by 2. Thanks, Eryu > +fi > + > echo "Silence is golden" > > _scratch_mkfs >>$seqres.full 2>&1 > -- > 1.9.3 > -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
