On Mon, Aug 10, 2015 at 09:15:41PM +0800, Eryu Guan wrote: > When testing 512 block size xfs, xfs/074 fails as > > QA output created by 074 > +fallocate: No space left on device > Silence is golden > > That's because 40051712*512=20G < 30G. > > Doubling the filesystem size makes the test on 512 block size xfs pass, > and test still fails on unpatched kernel. > > Signed-off-by: Eryu Guan <eguan@xxxxxxxxxx> > --- > tests/xfs/074 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/xfs/074 b/tests/xfs/074 > index a571a34..e6d6787 100755 > --- a/tests/xfs/074 > +++ b/tests/xfs/074 > @@ -62,7 +62,7 @@ mkdir -p $LOOP_MNT > $XFS_IO_PROG -ft -c "truncate 1t" $LOOP_FILE >> $seqres.full > LOOP_DEV=`_create_loop_device $LOOP_FILE` > > -_mkfs_dev -d size=40051712b,agcount=4 -l size=32m $LOOP_DEV > +_mkfs_dev -d size=80103424b,agcount=4 -l size=32m $LOOP_DEV > _mount $LOOP_DEV $LOOP_MNT That was sized to give AGs of a specific size, which originally contributed to the problem being exposed. You should change the block count specification to a size specification so the filesysetm being made on 4k block size filesystems remains unchanged. size = 40051712b = 40051712 * 4096 = 164,051,812,352 = 156452m i.e. +_mkfs_dev -d size=156452m,agcount=4 -l size=32m $LOOP_DEV Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
