Re: [PATCH 1/4] xfstests: if DEV_BSIZE is not defined, assume it to be 512

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Thu, Jul 30, 2015 at 10:13:58AM -0700, Christoph Hellwig wrote:
> > diff --git a/lib/str_to_bytes.c b/lib/str_to_bytes.c
> > index c0d7d97..d63e93b 100644
> > --- a/lib/str_to_bytes.c
> > +++ b/lib/str_to_bytes.c
> > @@ -44,7 +44,11 @@
> >   ****************************************************************************/
> >  
> >  #if linux
> > +#ifdef DEV_BSIZE
> >  #define B_MULT	DEV_BSIZE	/* block size */
> > +#else
> > +#define B_MULT	512		/* block size */
> > +#endif
> >  #endif
> 
> That ifdef Linux looks bogus too.  I's say just define it to 512
> bytes here unconditionally.

Ack, will do.

> Same here, drop all the ifdefs and just define it to 512.

Ditto

					- Ted
					
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux